Stop re-using the same XRFrame for all events and animation frames

immersive-web / webxr-polyfill

Use the WebXR Device API today, providing fallbacks to native WebVR 1.1 and Cardboard

Apache License 2.0

381 stars 84 forks source link

Stop re-using the same XRFrame for all events and animation frames #114

Closed toji closed 4 years ago

toji commented 4 years ago

As was pointed out in https://github.com/immersive-web/webxr/issues/905 the polyfill is currently re-using the same XRFrame for all animation callbacks and input events that are fired. While more efficient this is not compatible with the spec, and may cause content incompatibilities with native implementations.

lojjic commented 4 years ago

I happened across this issue while investigating the problem in issue #115 -- it may make sense for me to go ahead and fix this one in the same PR.

lojjic commented 4 years ago

See PR #116 which includes this fix

lojjic commented 4 years ago

Fixed by PR #116 - but I don't have permissions to close this issue it seems.

toji commented 4 years ago

Thanks for pointing that out! Closing.