immersive-web / webxr-polyfill

Use the WebXR Device API today, providing fallbacks to native WebVR 1.1 and Cardboard
Apache License 2.0
381 stars 84 forks source link

Fixes for XR animation frame loop #116

Closed lojjic closed 4 years ago

lojjic commented 4 years ago

Fixes:

Notes for Review:

lojjic commented 4 years ago

No worries! As conflicts go this is an easy one to unwrap, but thank you for the resolution tips.

Your other comments all make perfect sense, I'll work through them shortly.

lojjic commented 4 years ago

Conflicts are resolved (via rebase) and all the fixes from that first round of code review have been made.

I've now tested this with the webxr-samples repo without issue, but still welcome additional testcase sources. As well as hints around how to test the session suspension logic.

toji commented 4 years ago

Looks great! Thank you so much!