search

immersive-web / webxr-polyfill

Use the WebXR Device API today, providing fallbacks to native WebVR 1.1 and Cardboard
Apache License 2.0
378 stars 84 forks source link

Event subclass fix ios #133

Closed blairmacintyre closed 4 years ago

blairmacintyre commented 4 years ago

This is the code that fixes issue #130

jsantell commented 4 years ago

I misunderstood in #130, I'm following you now -- found more info (or at least the same problem) here; happy that this works! Could you squash this down to one commit? I'll merge it in then. Thank you!

blairmacintyre commented 4 years ago

pretend I'm a git noob (not a stretch); how do I squash to a single commit? :)

jsantell commented 4 years ago

pretend I'm a git noob (not a stretch); how do I squash to a single commit? :)

I use a shortcut git rebase -i HEAD~$1 where $1 is how many previous commits you'd like to squash -- then squash all commits except the top one (could be any commit really), and modify the final commit message. As is all things git, not sure if this is the correct way, but just the magical incantation I've internalized :smile:

blairmacintyre commented 4 years ago

I can't get it to work ... I seem to keep adding empty commits ... I'm just going to close this, it's a mess.

blairmacintyre commented 4 years ago

@jsantell I gave up on figuring out my git incompetance and just submitted a new PR #135