search

immersive-web / webxr-polyfill

Use the WebXR Device API today, providing fallbacks to native WebVR 1.1 and Cardboard
Apache License 2.0
378 stars 84 forks source link

Fix event names in XRSession #143

Closed takahirox closed 4 years ago

takahirox commented 4 years ago

If I'm right, XRSession uses event name @webvr-polyfill/* and @@webvr-polyfill/* at some places but I think they are typos because @webvr-polyfill/* or @@webvr-polyfill/* aren't used everywhere else but @@webxr-polyfill/* is used.

Even in the same XRSession here uses @@webxr-polyfill/* to register a listener but here uses @webvr-polyfill/* to remove the listener. The listener won't be removed because they use different names.

This PR fixes this problem by renaming @webvr-polyfill/* or @@webvr-polyfill/* to @@webxr-polyfill/*.

joshmarinacci commented 4 years ago

hey @toji could you take a look at this?

toji commented 4 years ago

Thanks for catching that!