select event immediately before selectend event

immersive-web / webxr-polyfill

Use the WebXR Device API today, providing fallbacks to native WebVR 1.1 and Cardboard

Apache License 2.0

378 stars 84 forks source link

select event immediately before selectend event #156

Closed De-Panther closed 3 years ago

De-Panther commented 3 years ago

As written in the working draft https://www.w3.org/TR/webxr/#xrinputsource-interface

Queue a task to perform the following steps:
Fire an input source event with name select, frame frame, and source source.
Fire an input source event with name selectend, frame frame, and source source

And in https://developer.mozilla.org/en-US/docs/Web/API/XRSession

The select event is sent after the selectstart event is sent and immediately before the selectend event is sent.

De-Panther commented 3 years ago

The build failed, but I see that all the builds are failing in past PRs. This PR should also solve an issue in the WebXR Emulator https://github.com/MozillaReality/WebXR-emulator-extension/issues/255

cc @toji

toji commented 3 years ago

Thanks! That was clearly a bug.