immersive-web / webxr-samples

Samples to demonstrate use of the WebXR Device API
https://immersive-web.github.io/webxr-samples/
MIT License
979 stars 474 forks source link

gl.stencilMask should not be set to a boolean #160

Closed dmliao closed 1 year ago

dmliao commented 1 year ago

gl.stencilMask expects a GLUint as its parameter, not a boolean value.

This is relevant for https://github.com/BabylonJS/Spector.js/pull/257; when running Spector.js on the webxr samples, captures would fail because Spector was expecting a numerical value in the stencilMask call and got a boolean instead.

I haven't dug super deep into the code, so am not entirely certain that the values I provided are the desired ones for the stencilMask call.