immersive-web / webxr-samples

Samples to demonstrate use of the WebXR Device API
https://immersive-web.github.io/webxr-samples/
MIT License
995 stars 479 forks source link

Inline-session Example Broken on Pixel2 #49

Open matthew-robertson opened 4 years ago

matthew-robertson commented 4 years ago

It seems like sometime within the last month, the inline-session example stopped supporting Magic Window mode, and the version without the polyfill seems to have stopped working entirely. The immersive-VR mode works as expected.

When attempting to view the sample without the polyfill, the debug console registers an issue about xr.isSessionSupported not being a function.

We have an app which makes use of WebXR, and in my investigation there, it seems like as of recently the local reference space no longer seems to be supported by the Pixel 2 (or we're now requesting it incorrectly), which may or may not be related.

Apologies for the rather messy issue description, but I've been having a bit of a time the last short while trying to figure out how to get Magic Window working in our app again.

bialpio commented 4 years ago

We have an app which makes use of WebXR, and in my investigation there, it seems like as of recently the local reference space no longer seems to be supported by the Pixel 2 (or we're now requesting it incorrectly), which may or may not be related.

If I'm not mistaken, local reference spaces should work in inline sessions only if they're listed as a required feature during session request - see feature dependencies in the spec and this link for an example on how to request features.

matthew-robertson commented 4 years ago

@bialpio Hmm. Adding it as a required feature seems to partially fix our issue. It seems like It's now managing to create the reference space, though its transform doesn't seem to update while inline. Once set to immersive it seems to update fine. Not sure what would have changed in WebXR over the last few weeks from when this last worked for us.