IPFS storage provider - Githubissues

gtfierro commented 6 years ago

Not implemented for now:

Enqueue
IterateQueue

I will take the time soon to write down exactly what we understand the issues are with implementing these directly over IPFS/IPNS so we can actually make the call if its possible.

Questions:

[x] Is this the proper way to instantiate a KECCAK-256 object?
[x] right now I'm assuming that the hashes provided to Get are KECCAK-256. What's the idiomatic way to check the format of the hash?

TODOs:

[x] set up some supernodes so that there are some running
[x] document how to add the supernodes to your IPFS config

immesys commented 6 years ago

The idiomatic way to check hash format is a type assertion: hashInstance.(*iapi.HashSchemeInstance_X)

gtfierro commented 6 years ago

OK cool I've used the type assertion in the latest commit. I have all of my questions answered now Is there anything you'd like me to add/fix for this to be merged in?

immesys commented 6 years ago

No, it looks fine at a code level. I might have feedback after I test it out, but I'll merge it as is.

immesys / wave

IPFS storage provider #2