search

immibis / bearded-octo-nemesis

Now 99.9% fat free!
128 stars 31 forks source link

Some things are ignored when using reob #8

Open monoxide0184 opened 11 years ago

monoxide0184 commented 11 years ago

I'm having issues in specific situations when trying to use reob to reobfuscate a mod. Specifically here's some examples I've pulled out with JD-GUI from the reob'ed jar. These two examples are from two different classes.

public <T extends Item> T getItem(String name)
{
  return (up)this.registeredMinecraftObjects.get(name);
}

// FloodFillState is a mod class
private List<FloodFillState> getBlocksToBreak(World world, int x, int y, int z, Block wood, int woodMeta, Block leaves, int leavesMeta) {
  // ... <snip>
}

These seem to be representative of all the issues we've run into.

immibis commented 11 years ago

It doesn't handle generics at all, and reob hasn't been tested at all (there's a reason it's not in the GUI). Btw, why aren't you using MCP for reob?

monoxide0184 commented 11 years ago

It'd probably be easier to show rather than tell: https://github.com/monoxide0184/ForgeBackup/blob/master/build.xml

In short, we have a separate src folder from MCP and to date that project has also compiled to our own bin folder too. BON worked great for that (small) project, but when I tried to move that build system across to a larger project I ran into the issues above. Reason I want to stick with this system? Well, mostly because 4 second builds in jenkins are awesome. I may just try to hack it together with MCP's reobf though if this really isn't supported in BON.

wgaylord commented 9 years ago

Sorry for the bump. MCP uses SS to reobf plus the mappings.