search

immich-app / immich-charts

Helm chart implementation of Immich
https://immich.app
GNU Affero General Public License v3.0
107 stars 45 forks source link

Update App Version to 1.79.1 #42

Closed hofq closed 11 months ago

hofq commented 11 months ago

Update Chart Version, as the last commit has not created an Release

hofq commented 11 months ago

Runs stable, without any new Bugs in Android and Web App grafik

PixelJonas commented 11 months ago

LGTM

bo0tzz commented 11 months ago

Fwiw: We shouldn't need to do chart releases just to update the app version, as people can override it in their own values.yaml

PixelJonas commented 11 months ago

yeah, I thought about moving the image tag to release. This would mean that we should be fast for adapting to breaking changes.

Do you agree @bo0tzz ?

bo0tzz commented 11 months ago

No, I disagree. There is no real need to keep the default image tag in the chart up to date (although we should still bump it if we're doing a release for other reasons), and I'm also not a fan in general of mutable/moving tags like release ;)

hofq commented 11 months ago

Would be nice if there are regular updates to the Chart because users then know that the Chart works with the specified image.

Also as the Chart is official, synced release Versions keep it simple to rollback or trace back any issues.

Also this would remove the need for external tools like argo image updater to keep the Image up to date

Maybe a Dependency Bot would be nice to just merge a new image after testing

PixelJonas commented 11 months ago

I see your point @hofq but without having something like a CI/CD pipeline to test the chart against the latest Immich release this might introduce another set of challenges. Testing new versions can be easily done by anyone by changing the image.tag