search

immich-app / immich-charts

Helm chart implementation of Immich
https://immich.app
GNU Affero General Public License v3.0
106 stars 45 forks source link

Update to Immich v1.82.0 #46

Closed djjudas21 closed 10 months ago

bo0tzz commented 10 months ago

Thanks for the PR! There is no need to update the app version in the chart as you can override it in your own values.yaml, see https://github.com/immich-app/immich-charts/pull/42#issuecomment-1742000039.

djjudas21 commented 10 months ago

Yes, I'm aware I can override the image version in the values, but in all the Helm charts I maintain I make a point of tracking the releases closely in the helm chart so end users can simply helm install and get the latest version.

I guess it's a decision to be made by the maintainer, but my preference if that users should never have to override the image version unless they're experimenting. It causes a risk of people being stuck on an old version without realising. Frequent updates to the Helm chart also looks good on ArtifactHub, which prominently displays the last update time, and the supported version. Charts that appear to be old and unmaintained deter users.

Ideally the Helm chart upgrade action would be automatic when a new release is tagged, but I'm still happy to manually submit PRs for the Helm chart bump if you'd like me to. Thanks :slightly_smiling_face:

nilzen commented 9 months ago

I'm not a Helm chart maintainer, but I still agree with @djjudas21 here. I was actually wondering if this Helm chart had been abandoned before the update to 1.88 a few days ago and was looking at other deployment options for my first setup. Then, I noticed that it had been updated to 1.88 so I will go with this chart anyways.