search

immich-app / immich-charts

Helm chart implementation of Immich
https://immich.app
GNU Affero General Public License v3.0
92 stars 39 forks source link

fix(servicemonitor): patch metrics labels to prefix with immich_ #89

Open hiteshnayak305 opened 3 months ago

hiteshnayak305 commented 3 months ago

Description of the change

Add immich_ prefix to metrics labels as per discussion https://github.com/immich-app/immich/discussions/8191#discussioncomment-9043115

Should be reverted when https://github.com/pragmaticivan/nestjs-otel/issues/265 is fixed

Applicable issues

hiteshnayak305 commented 3 months ago

do we have list of metrices, i tried in my local k8s cluster. will look into once it again.

hiteshnayak305 commented 3 months ago

I am unable to see any metrics mentioned in that discussion. Not sure if something missing in my configuration ? immich_server_container

immich_server_8081_metrics.txt

bo0tzz commented 3 months ago

It seems they only exist for jobs. Maybe if you haven't run any jobs since starting the pod, it doesn't export those metrics? image

hiteshnayak305 commented 3 months ago

as per this comment https://github.com/immich-app/immich/discussions/8191#discussioncomment-9095910 suggested regex is not compiling in prometheus. not sure how to proceed.