immich-app / immich

High performance self-hosted photo and video management solution.
https://immich.app
GNU Affero General Public License v3.0
44.56k stars 2.17k forks source link

White text and icons are not visible on photo & video previews with light background #10213

Open Maxobus opened 3 months ago

Maxobus commented 3 months ago

The bug

If the photo or video preview has image with light background then white text and icons are not visible. When you hover over the preview, it is shaded and the text becomes visible. Thus, scrolling timeline, it is impossible to determine whether the asset is a video or a photo unless you interact with it. Especially in the mobile app, where you can't hover.

SUGGESTION is to add shading glow effect or similar to icons and text.

image image

The OS that Immich Server is running on

Ubuntu 22.04.4 LTS

Version of Immich Server

v1.106.2

Version of Immich Mobile App

v1.10.6.1 build.142

Platform with the issue

Your docker-compose.yml content

services:
  immich-server:
    container_name: immich_server
    image: ghcr.io/immich-app/immich-server:${IMMICH_VERSION:-release}

    volumes:
      - ${UPLOAD_LOCATION}:/usr/src/app/upload
      - ${THUMBS_LOCATION}:/usr/src/app/upload/thumbs
      - /NAS/POISON/! BACKUPS !/Camera Upload:/mnt/media/camera_upload:ro
      - /etc/localtime:/etc/localtime:ro
    env_file:
      - .env
    ports:
      - 2283:3001
    depends_on:
      - redis
      - database
    restart: no

  immich-machine-learning:
    container_name: immich_machine_learning
    image: ghcr.io/immich-app/immich-machine-learning:${IMMICH_VERSION:-release}

    volumes:
      - model-cache:/cache
    env_file:
      - .env
    restart: no

  redis:
    container_name: immich_redis
    image: registry.hub.docker.com/library/redis:6.2-alpine@sha256:84882e87b54734154586e5f8abd4dce69fe7311315e2fc6d67c29614c8de2672
    restart: no

  database:
    container_name: immich_postgres
    image: registry.hub.docker.com/tensorchord/pgvecto-rs:pg14-v0.2.0@sha256:90724186f0a3517cf6914295b5ab410db9ce23190a2d9d0b9dd6463e3fa298f0
    environment:
      POSTGRES_PASSWORD: ${DB_PASSWORD}
      POSTGRES_USER: ${DB_USERNAME}
      POSTGRES_DB: ${DB_DATABASE_NAME}
      POSTGRES_INITDB_ARGS: '--data-checksums'
    volumes:
      - ${DB_DATA_LOCATION}:/var/lib/postgresql/data
    restart: no
    command: ["postgres", "-c" ,"shared_preload_libraries=vectors.so", "-c", 'search_path="$$user", public, vectors', "-c", "logging_collector=on", "-c", "max_wal_size=2GB", "-c", "shared_buffers=512MB", "-c", "wal_compression=on"]

volumes:
  model-cache:

Your .env content

UPLOAD_LOCATION=/NAS/CLOUD/immich/upload
THUMBS_LOCATION=/mnt/CACHEDISK/immich/upload/thumbs
DB_DATA_LOCATION=/NAS/CLOUD/immich/postgres
IMMICH_VERSION=release
DB_PASSWORD=[...]
DB_USERNAME=[...]
DB_DATABASE_NAME=[...]

Reproduction steps

Relevant log output

No response

Additional information

No response

aten2005 commented 1 month ago

Can I work on this?

iswaterbad commented 1 month ago

I think there is the same issue with the upload status icon on mobile. (Especially for screenshots with a white background)