search

immich-app / immich

High performance self-hosted photo and video management solution.
https://immich.app
GNU Affero General Public License v3.0
52.41k stars 2.78k forks source link

Partial panoramas/photospheres display incorrectly as full 360° #10917

Open jenda69 opened 4 months ago

jenda69 commented 4 months ago

The bug

I have a bunch of panoramas with an equirectangular projection that are not full 360° sphere and since v 1.106, they started displaying stretched out and wrapped around the whole 360° sphere. For example like this: image It used to be displayed correctly in v1.105 (see the screenshot of the same panorama in #9801 where the edges don't "touch" in the back)

The OS that Immich Server is running on

Raspberry OS Bookworm

Version of Immich Server

v1.117.2

Version of Immich Mobile App

N/A

Platform with the issue

Your docker-compose.yml content

N/A

Your .env content

N/A

Reproduction steps

1. Open non 360° panorama with an equirectangular projection on the web

Relevant log output

No response

Additional information

No response

jenda69 commented 4 months ago

This might be related to issue #10297 - the panorama viewer gets the preview file which doesn't contain EXIF tags for photosphere and therefore it defaults to stretching the panorama around.

jenda69 commented 2 months ago

After #12222, partial panoramas still display incorrectly wrapped around the sphere when you open them. But when you zoom in, as soon as full panorama gets loaded, it displays correctly.

This could be corrected by copying the spherical metadata into thumbnail image. Not sure but the they should probably be also recalculated to accommodate the resolution change.

gruppler commented 1 day ago

But when you zoom in, as soon as full panorama gets loaded, it displays correctly.

I'm not seeing this behavior. Partial panoramas are displayed as full 360 even after fully loading the image and zooming in (on Immich v1.121.0).