immich-app / immich

High performance self-hosted photo and video management solution.
https://immich.app
GNU Affero General Public License v3.0
43.48k stars 2.12k forks source link

[UI] Unnatural date format used in search #10992

Open null-von-sushi opened 1 month ago

null-von-sushi commented 1 month ago

The bug

Searching currently requires users to enter the date in MM/DD/YYYY format. While I understand that immich is American software, it has users around the world and the majority of the word works in either ascending or descending order (DD/MM/YYYY for the west, YYYY/MM/DD for the east). Please would you consider implementing a setting that allows us to specify the date in either of the two? Thank you for your consideration

The OS that Immich Server is running on

TrueNAS

Version of Immich Server

v1.107.2

Version of Immich Mobile App

N/A

Platform with the issue

Your docker-compose.yml content

Not sure, I did not use docker. TrueNAS abstracts all this in it's webui when installing apps...

Your .env content

Same as above.

Reproduction steps

1. Open your immich instance's website
2. Click the settings icon next to the search bar at the top
3. Observe the date input field asking for MM/DD/YYYY

Relevant log output

N/A

Additional information

No response

bo0tzz commented 1 month ago

This should probably be changed to use the locale from the user settings.

michelheusschen commented 1 month ago

The date format is already based on the configured language and nothing is forcing the date format to be mm/dd/yyyy. When I set my language to Japanese for example, the date format changes:

image

bo0tzz commented 1 month ago

@michelheusschen it should be based on locale, not language.

andrebrait commented 1 month ago

Yes, I second that. Language and locale aren't the same thing and date format here should be derived from locale (e.g. en_GB uses dd/mm/yyyy, en_IE use dd-mm-yyyy but also sometimes dd/mm/yyyy, whereas en-US uses mm-dd-yyyy).

And many locales don't use / as a separator either (e.g. nl_NL uses -, also see examples above)

WhiteWoodenWall commented 2 weeks ago

if I change both my language and custom locale to Japanese, I am still presented with the mm/dd/yyyy format. Perhaps the default browser locale/language setting is taking priority?