immich-app / immich

High performance self-hosted photo and video management solution.
https://immich.app
GNU Affero General Public License v3.0
44.63k stars 2.17k forks source link

Mobile editor doesn't respect the image paths #11472

Open samolego opened 1 month ago

samolego commented 1 month ago

The bug

I have the Camera folder set up to be backup up by immich (/storage/emulated/0/DCIM/Camera). When I edit the pictures using the new edit function, new images don't show up in the gallery. I manually looked for them in file explorer and found them in Pictures folder (/storage/emulated/0/Pictures).

This is not really intuitive, as I thought the feature is broken and doesn't do anything. The new file should be created within the same folder IMHO.

The OS that Immich Server is running on

DietPi v9.6.1

Version of Immich Server

1.110.0

Version of Immich Mobile App

1.111.0 (152)

Platform with the issue

Your docker-compose.yml content

#
# WARNING: Make sure to use the docker-compose.yml of the current release:
#
# https://github.com/immich-app/immich/releases/latest/download/docker-compose.yml
#
# The compose file on main may not be compatible with the latest release.
#

name: immich

services:
  immich-server:
    container_name: immich_server
    image: ghcr.io/immich-app/immich-server:${IMMICH_VERSION:-release}
    # extends:
    #   file: hwaccel.transcoding.yml
    #   service: cpu # set to one of [nvenc, quicksync, rkmpp, vaapi, vaapi-wsl] for accelerated transcoding
    volumes:
      - ${UPLOAD_LOCATION}:/usr/src/app/upload
      - /etc/localtime:/etc/localtime:ro
    env_file:
      - .env
    ports:
      - 2283:3001
    depends_on:
      - redis
      - database
    restart: always

  immich-machine-learning:
    container_name: immich_machine_learning
    # For hardware acceleration, add one of -[armnn, cuda, openvino] to the image tag.
    # Example tag: ${IMMICH_VERSION:-release}-cuda
    image: ghcr.io/immich-app/immich-machine-learning:${IMMICH_VERSION:-release}
    # extends: # uncomment this section for hardware acceleration - see https://immich.app/docs/features/ml-hardware-acceleration
    #   file: hwaccel.ml.yml
    #   service: cpu # set to one of [armnn, cuda, openvino, openvino-wsl] for accelerated inference - use the `-wsl` version for WSL2 where applicable
    volumes:
      - model-cache:/cache
    env_file:
      - .env
    restart: always

  redis:
    container_name: immich_redis
    image: docker.io/redis:6.2-alpine@sha256:328fe6a5822256d065debb36617a8169dbfbd77b797c525288e465f56c1d392b
    healthcheck:
      test: redis-cli ping || exit 1
    restart: always

  database:
    container_name: immich_postgres
    image: docker.io/tensorchord/pgvecto-rs:pg14-v0.2.0@sha256:90724186f0a3517cf6914295b5ab410db9ce23190a2d9d0b9dd6463e3fa298f0
    environment:
      POSTGRES_PASSWORD: ${DB_PASSWORD}
      POSTGRES_USER: ${DB_USERNAME}
      POSTGRES_DB: ${DB_DATABASE_NAME}
      POSTGRES_INITDB_ARGS: '--data-checksums'
    volumes:
      - ${DB_DATA_LOCATION}:/var/lib/postgresql/data
    healthcheck:
      test: pg_isready --dbname='${DB_DATABASE_NAME}' --username='${DB_USERNAME}' || exit 1; Chksum="$$(psql --dbname='${DB_DATABASE_NAME}' --username='${DB_USERNAME}' --tuples-only --no-align --command='SELECT COALESCE(SUM(checksum_failures), 0) FROM pg_stat_database')"; echo "checksum failure count is $$Chksum"; [ "$$Chksum" = '0' ] || exit 1
      interval: 5m
      start_interval: 30s
      start_period: 5m
    command: ["postgres", "-c" ,"shared_preload_libraries=vectors.so", "-c", 'search_path="$$user", public, vectors', "-c", "logging_collector=on", "-c", "max_wal_size=2GB", "-c", "shared_buffers=512MB", "-c", "wal_compression=on"]
    restart: always

volumes:
  model-cache:

Your .env content

# You can find documentation for all the supported env variables at https://immich.app/docs/install/environment-variables

# The location where your uploaded files are stored
UPLOAD_LOCATION=/mnt/dietpi_userdata/immich_data/library
# The location where your database files are stored
DB_DATA_LOCATION=/mnt/dietpi_userdata/immich_data/postgres

# To set a timezone, uncomment the next line and change Etc/UTC to a TZ identifier from this list: https://en.wikipedia.org/wiki/List_of_tz_database_time_zones#List
TZ=Europe/Belgrade

# The Immich version to use. You can pin this to a specific version like "v1.71.0"
IMMICH_VERSION=release

# passwords are ommited

Reproduction steps

1. Take a photo which will be saved in other folder than `Pictures`.
2. Go to edit menu and crop it.
3. Picture won't show up unless you have backup enabled for the `Pictures` folder

Relevant log output

No response

Additional information

No response

thomasss02 commented 1 month ago

Also the name of file should be the name of the original photo + _edited. EDIT The saved edited photo has .jpg extension but metadata shows image/png as MIME type. All other metadata of the original photo is not copied.

se7entynine commented 1 month ago

Can you confirm that the file size is also way lower then the original? I just rotated an image and the saved image was only a 10th of the original one.

thomasss02 commented 1 month ago

My original file size is 4MB, the rotated file size is 14MB

Can you confirm that the file size is also way lower then the original? I just rotated an image and the saved image was only a 10th of the original one.

Yuvi-raj-P commented 1 month ago

Thanks for the Issue, we are working on the fix and it will be out by this weekend or next week. I am not sure about the original size not being equal to the edited file size but will get other issues fixed! Thanks for your feedback 🙂.

Yuvi-raj-P commented 1 month ago

Also the name of file should be the name of the original photo + _edited. EDIT The saved edited photo has .jpg extension but metadata shows image/png as MIME type. All other metadata of the original photo is not copied.

Working on the file location and metadata. Just got the naming fixed #11503

se7entynine commented 1 month ago

Tried it again with the same picture and it has the original filesize. Not sure what caused that error. A little feedback - I'd love to rotate the pictures on the server without downloading them to the phone first. Thanks for your contribution!