immich-app / immich

High performance self-hosted photo and video management solution.
https://immich.app
GNU Affero General Public License v3.0
45.1k stars 2.19k forks source link

Inconsistent availability of "add to album" for shared assets #11840

Open C-Otto opened 1 month ago

C-Otto commented 1 month ago

The bug

I can add assets shared with me to albums, but not all of the known options to do so are available. For this, I assume that my partner shares everything with me, and that I configured my timeline to include those shared assets.

  1. Click on asset in timeline -> three dots -> Add to album: option is only shown for owned assets
  2. Select asset(s) in timeline (checkmark in upper left corner) -> click "+" in upper right corner -> Add to album: works for both owned and unowned assets
  3. Navigate to album -> Add photos (upper right): only shows owned assets in timeline (even though the regular timeline also shows unowned assets)
  4. Sharing -> click on partner in "Partners" -> click on asset: same as 1.
  5. Sharing -> click on partner in "Partners" -> select assets: same as 2.

As I'm able to add unowned assets to my albums via some of those options, I expect the other options to work, too.

The OS that Immich Server is running on

Debian Stable

Version of Immich Server

v1.112.1

Platform with the issue

C-Otto commented 1 month ago

According to the server's permission checks, I am allowed to add an asset to an album if:

As such, I believe all assets shown in my timeline should also show the "add to album" option.

Furthermore, the assets shown for 3. (from album via "Add photos") should include show the full timeline (including my partners' assets). This might be a different issue, though.

ahayzen commented 1 month ago

Is this related or a duplicate of #6486 ?

C-Otto commented 1 month ago

Related. That ticket only covers 3. of my list, I think.