search

immich-app / immich

High performance self-hosted photo and video management solution.
https://immich.app
GNU Affero General Public License v3.0
44.63k stars 2.17k forks source link

Assets shared though an album cannot be shared with a link #11877

Open agross opened 3 weeks ago

agross commented 3 weeks ago

The bug

  1. Create an album and share it with another user
  2. Let the other user add e.g. an image
  3. Open the image
  4. Click the share icon and create a link
  5. "Not found or no asset.share access" error shows up

The OS that Immich Server is running on

docker

Version of Immich Server

1.112.1

Version of Immich Mobile App

unrelated

Platform with the issue

Your docker-compose.yml content

unrelated

Your .env content

unrelated

Reproduction steps

1. See above

Relevant log output

No response

Additional information

No response

parkjaeil0x01 commented 3 weeks ago

Same problem here.

  1. Select an album
  2. Open a photo
  3. Trying to create a share link
  4. Then... boom.

image

But, I can create share links which I created or owned photos, videos and albums.

I don't know what trigger is this issue, however, in my case, the album was created by me(admin) and my friends were upload their photos and videos and then, added their medias into the album.

jrasm91 commented 3 weeks ago

This is working as designed, but we can probably change the access rules to allow re-sharing photos that have been shared with you.

parkjaeil0x01 commented 3 weeks ago

This is working as designed, but we can probably change the access rules to allow re-sharing photos that have been shared with you.

Is there anyway to do it myself? or need to edit some codes in Immich?

And here is my another question... if I understood it as well, photos and videos are not gonna be shared at that condition(an album and others uploads into a same album). But, why the sharing icon is visible at that moment? I think it should be disabled or invisible if we cannot create a share link at that scenario.