search

immich-app / immich

High performance self-hosted photo and video management solution.
https://immich.app
GNU Affero General Public License v3.0
52.62k stars 2.79k forks source link

[WEB] Search display filters (not in album, archive, favorites) act inconsistently #14211

Open weathondev opened 1 week ago

weathondev commented 1 week ago

The bug

If you dont have 'not in album', 'favorites' and 'archive' checked, it will show you pictures that are (in albums or not) (in favorites or not) (not archived) - this is inconsistent. It might be the desired behavior but then we should rename them to 'Favorites only' and 'include archive'. @mertalev suggested to do three-way toggles (all/matching/not matching) which is probably the best solution and we just need to think of the proper defaults.

The OS that Immich Server is running on

Not relevant

Version of Immich Server

v1.120.2

Version of Immich Mobile App

-

Platform with the issue

Your docker-compose.yml content

not relevant

Your .env content

not relevant

Reproduction steps

1. 2. 3. ...

Relevant log output

No response

Additional information

No response

weathondev commented 1 week ago

I can tackle this one after my current task but wanted to document it already as found it while on my current one.