Closed PeterBasista closed 1 year ago
Hey, thanks for reporting this issue. I think as this is something that won't happen moving forward, it might be a case of manually fixing them in your instance. It should be relatively simple to do with a SQL query, if you want help with that then let us know!
Thank you very much for the information.
In this case, I am closing the BUG and also providing an SQL command for future searchers.
DELETE FROM albums_assets_assets
where "assetsId" in (
select "assetsId" from albums_assets_assets aaa
left join assets a on aaa."assetsId" = a.id
where a."isVisible" = false
);
I believe the issue is that both asset ids (for still and motion) were added to the album and then one of them was set to isVisible: false
afterwards (via the auto-linking process). So two things are going on here:
isVisible: false
be displayed if it's specifically included in the list of assets in an album. I think the answer here has to be yes. We don't have any code that prevents albums from display hidden assets. That property has always been designed for hiding assets from the main timeline. We could extend this to albums, but it just doesn't make sense. Why would you add a hidden asset to an album, if you don't want it to show up in the album?So, have to agree with @zackpollard here, the easiest thing would just be to manually clean them up. We theoretically could have written code to do this as part of the last release, but we're minimizing how much effort we spend on "one time fixes" like this.
The bug
After the last update the option to pair live photos automatically was added, the only thing you need to do is to extract the metadata again. I did this step and all live photos paired nicely. But after pairing there was a problem. In the albums that have already been made, the video still shows and the livephoto next to it (when clicked, it also starts to move).
This problem does not occur on the main screen. Only for albums.
The problem is that the assets are selected in the albums according to what is in the DB but it doesn't check if the given item is "isVisible" or not.
*I have already reported this problem once, but it was only a problem for me as I was pairing live photos manually.
The OS that Immich Server is running on
Rasbian 10 buster
Version of Immich Server
v1.49.0
Version of Immich Mobile App
1.49.0 build.87
Platform with the issue
Your docker-compose.yml content
Your .env content
Reproduction steps
Additional information