immich-app / immich

High performance self-hosted photo and video management solution.
https://immich.app
GNU Affero General Public License v3.0
51.08k stars 2.7k forks source link

[BUG] Immich doesn't notify of duplicate uploads #2557

Closed uhthomas closed 1 year ago

uhthomas commented 1 year ago

The bug

Nothing happens when attempting to upload a file which already exists. It would be nice if there was some feedback which said it was successful or that it is a duplicate rather than just doing nothing.

{"isExist":true,"id":"703b63e9-a71d-4b5c-8149-0bd6d45010bd"}

The OS that Immich Server is running on

Arch Linux

Version of Immich Server

1.57.1

Version of Immich Mobile App

N/A

Platform with the issue

Your docker-compose.yml content

N/A

Your .env content

N/A

Reproduction steps

1. Upload a file.
2. Upload the same file again.
3. Observe nothing happens.

Additional information

No response

Sherlock1979 commented 1 year ago

Same for CLI. When uploading assets and then manually comparing number of files I noticed a small mismatch (in my case 46 of 22k photos). I thought that upload failed and rerun it a few times but nothing changed.

According to CLI there were 0 errors.

Alex pointed out that these 46 assets may be duplicates and he was correct indeed.

So, as you rightly said, even in the CLI "It would be nice if there was some feedback which said it was successful or that it is a duplicate rather than just doing nothing."

DX37 commented 1 year ago

I had to reinstall Immich after firmware factory reset, and then app proceeds to upload all my photos all over again and duplicates them.