immich-app / immich

High performance self-hosted photo and video management solution.
https://immich.app
GNU Affero General Public License v3.0
44.84k stars 2.18k forks source link

[BUG] Web stops functioning on one account when map opened #2625

Closed Harris-KA closed 1 year ago

Harris-KA commented 1 year ago

The bug

On the web on one certain account I recently added about 6000 photos to the map shows only 86 photos in Edinburgh but there is many with other geolocations and after I have gone into the map tab all the other buttons everywhere on the screen do not work and I have to type in the address again to navigate anywhere else. I have tried restarting the container and extracting all metadata again but nothing changes. Sorry if I'm wrong in any of this too I am new to this but am loving everything else!

The OS that Immich Server is running on

Docker in unraid

Version of Immich Server

v1.15.9

Version of Immich Mobile App

v1.59.0 build.82

Platform with the issue

Your docker-compose.yml content

version: "3.8"

services:
  immich-server:
    container_name: immich_server
    image: ghcr.io/immich-app/immich-server:release
    command: ["start-server.sh"]
    volumes:
      - ${UPLOAD_LOCATION}:/usr/src/app/upload
    env_file:
      - .env
    depends_on:
      - redis
      - database
      - typesense
    restart: always

  immich-microservices:
    container_name: immich_microservices
    image: ghcr.io/immich-app/immich-server:release
    command: ["start-microservices.sh"]
    volumes:
      - ${UPLOAD_LOCATION}:/usr/src/app/upload
    env_file:
      - .env
    depends_on:
      - redis
      - database
      - typesense
    restart: always

  immich-machine-learning:
    container_name: immich_machine_learning
    image: ghcr.io/immich-app/immich-machine-learning:release
    volumes:
      - ${UPLOAD_LOCATION}:/usr/src/app/upload
      - model-cache:/cache
    env_file:
      - .env
    restart: always

  immich-web:
    container_name: immich_web
    image: ghcr.io/immich-app/immich-web:release
    env_file:
      - .env
    restart: always

  typesense:
    container_name: immich_typesense
    image: typesense/typesense:0.24.0
    environment:
      - TYPESENSE_API_KEY=${TYPESENSE_API_KEY}
      - TYPESENSE_DATA_DIR=/data
    logging:
      driver: none
    volumes:
      - tsdata:/data
    restart: always

  redis:
    container_name: immich_redis
    image: redis:6.2
    restart: always

  database:
    container_name: immich_postgres
    image: postgres:14
    env_file:
      - .env
    environment:
      POSTGRES_PASSWORD: ${DB_PASSWORD}
      POSTGRES_USER: ${DB_USERNAME}
      POSTGRES_DB: ${DB_DATABASE_NAME}
      PG_DATA: /var/lib/postgresql/data
    volumes:
      - pgdata:/var/lib/postgresql/data
    restart: always

  immich-proxy:
    container_name: immich_proxy
    image: ghcr.io/immich-app/immich-proxy:release
    environment:
      # Make sure these values get passed through from the env file
      - IMMICH_SERVER_URL
      - IMMICH_WEB_URL
    ports:
      - 2283:8080
    depends_on:
      - immich-server
    restart: always

volumes:
  pgdata:
  model-cache:
  tsdata:

Your .env content

###################################################################################
# Database
###################################################################################

# NOTE: The following four database variables support Docker secrets by adding a *_FILE suffix to the variable name
# See the docker-compose documentation on secrets for additional details: https://docs.docker.com/compose/compose-file/compose-file-v3/#secrets
DB_HOSTNAME=immich_postgres
DB_USERNAME=postgres
DB_PASSWORD=postgres
DB_DATABASE_NAME=immich

# Optional Database settings:
# DB_PORT=5432

###################################################################################
# Redis
###################################################################################

REDIS_HOSTNAME=immich_redis

# REDIS_URL will be used to pass custom options to ioredis.
# Example for Sentinel
# {"sentinels":[{"host":"redis-sentinel-node-0","port":26379},{"host":"redis-sentinel-node-1","port":26379},{"host":"redis-sentinel-node-2","port":26379}],"name":"redis-sentinel"}
# REDIS_URL=ioredis://eyJzZW50aW5lbHMiOlt7Imhvc3QiOiJyZWRpcy1zZW50aW5lbDEiLCJwb3J0IjoyNjM3OX0seyJob3N0IjoicmVkaXMtc2VudGluZWwyIiwicG9ydCI6MjYzNzl9XSwibmFtZSI6Im15bWFzdGVyIn0=

# Optional Redis settings:

# Note: these parameters are not automatically passed to the Redis Container
# to do so, please edit the docker-compose.yml file as well. Redis is not configured
# via environment variables, only redis.conf or the command line

# REDIS_PORT=6379
# REDIS_DBINDEX=0
# REDIS_USERNAME=
# REDIS_PASSWORD=
# REDIS_SOCKET=

###################################################################################
# Upload File Location
#
# This is the location where uploaded files are stored.
###################################################################################

UPLOAD_LOCATION=/mnt/user/phoneupload

###################################################################################
# Typesense
###################################################################################
TYPESENSE_API_KEY=some-random-text
# TYPESENSE_ENABLED=false
# TYPESENSE_URL uses base64 encoding for the nodes json.
# Example JSON that was used:
# [
#      { 'host': 'typesense-1.example.net', 'port': '443', 'protocol': 'https' },
#      { 'host': 'typesense-2.example.net', 'port': '443', 'protocol': 'https' },
#      { 'host': 'typesense-3.example.net', 'port': '443', 'protocol': 'https' },
#  ]
# TYPESENSE_URL=ha://WwogICAgeyAnaG9zdCc6ICd0eXBlc2Vuc2UtMS5leGFtcGxlLm5ldCcsICdwb3J0JzogJzQ0MycsICdwcm90b2NvbCc6ICdodHRwcycgfSwKICAgIHsgJ2hvc3QnOiAndHlwZXNlbnNlLTIuZXhhbXBsZS5uZXQnLCAncG9ydCc6ICc0NDMnLCAncHJvdG9jb2wnOiAnaHR0cHMnIH0sCiAgICB7ICdob3N0JzogJ3R5cGVzZW5zZS0zLmV4YW1wbGUubmV0JywgJ3BvcnQnOiAnNDQzJywgJ3Byb3RvY29sJzogJ2h0dHBzJyB9LApd

###################################################################################
# Reverse Geocoding
#
# Reverse geocoding is done locally which has a small impact on memory usage
# This memory usage can be altered by changing the REVERSE_GEOCODING_PRECISION variable
# This ranges from 0-3 with 3 being the most precise
# 3 - Cities > 500 population: ~200MB RAM
# 2 - Cities > 1000 population: ~150MB RAM
# 1 - Cities > 5000 population: ~80MB RAM
# 0 - Cities > 15000 population: ~40MB RAM
####################################################################################

# DISABLE_REVERSE_GEOCODING=false
# REVERSE_GEOCODING_PRECISION=3

####################################################################################
# WEB - Optional
#
# Custom message on the login page, should be written in HTML form.
# For example:
# PUBLIC_LOGIN_PAGE_MESSAGE="This is a demo instance of Immich.<br><br>Email: <i>demo@demo.de</i><br>Password: <i>demo</i>"
####################################################################################

PUBLIC_LOGIN_PAGE_MESSAGE=

####################################################################################
# Alternative Service Addresses - Optional
#
# This is an advanced feature for users who may be running their immich services on different hosts.
# It will not change which address or port that services bind to within their containers, but it will change where other services look for their peers.
# Note: immich-microservices is bound to 3002, but no references are made
####################################################################################

IMMICH_WEB_URL=http://immich-web:3000
IMMICH_SERVER_URL=http://immich-server:3001
IMMICH_MACHINE_LEARNING_URL=http://immich-machine-learning:3003

####################################################################################
# Alternative API's External Address - Optional
#
# This is an advanced feature used to control the public server endpoint returned to clients during Well-known discovery.
# You should only use this if you want mobile apps to access the immich API over a custom URL. Do not include trailing slash.
# NOTE: At this time, the web app will not be affected by this setting and will continue to use the relative path: /api
# Examples: http://localhost:3001, http://immich-api.example.com, etc
####################################################################################

#IMMICH_API_URL_EXTERNAL=http://localhost:3001

Reproduction steps

1. Navigate to map tab
2. Only shows a couple locations
3. No other buttons work anymore

Additional information

No response

alextran1502 commented 1 year ago

Hello, which browser are you using? And can you open the developer panel using F12 and navigate to the Console tab to see if there is any error popping up when you navigate to the map page?

Harris-KA commented 1 year ago

Hi, I have tried Edge, Chrome and Brave. The error I get in the console is this:

image
michelheusschen commented 1 year ago

Would you be able to share some data? This will contain the location (gps coordinates) of all assets, but no other sensitive information.

  1. Go to yourdomain.com/api/asset/map-marker
  2. Save the page by pressing CTRL + S
  3. You should now have a map-marker.json file
Harris-KA commented 1 year ago

Hi I can't upload jsons in comments so here is the document I added .txt on: map-marker.txt

michelheusschen commented 1 year ago

The server sends invalid coordinates (null values) causing the map to crash when it encounters them. That's a bit strange, because the server shouldn't be able to send those values. The server version v1.15.9 you mentioned doesn't exist, could you check the version again?

Harris-KA commented 1 year ago

Sorry I typed it in wrong, the version is v1.59.1 in unraid docker compose. Also the photos were uploaded through mobile backup if that helps but only the 82 are showing before it crashes.

michelheusschen commented 1 year ago

The 83rd photo has invalid coordinates, so only showing 82 makes sense. Haven't been able to reproduce the issue, even with mobile uploads. Could you share the data returned by yourdomain.com/api/asset/assetById/4133570a-0700-43d9-beb7-709dad96cf50?

Harris-KA commented 1 year ago

{"id":"4133570a-0700-43d9-beb7-709dad96cf50","deviceAssetId":"1000020640","ownerId":"ad715c30-0d24-4d9e-88d3-2f35d5e085f4","deviceId":"fba61c25726651f4cdf1fa08c838f39b3f94f4ab6e837021d7d054581400c980","type":"IMAGE","originalPath":"upload/library/ad715c30-0d24-4d9e-88d3-2f35d5e085f4/2023/2023-05-17/IMG_9980.jpg","originalFileName":"IMG_9980","resized":true,"fileCreatedAt":"2023-05-17T15:26:03.000Z","fileModifiedAt":"2023-05-23T22:26:54.000Z","updatedAt":"2023-05-31T17:23:44.389Z","isFavorite":false,"isArchived":false,"mimeType":"image/jpeg","duration":"0:00:00.000000","exifInfo":{"make":"Apple","model":"iPhone 13 Pro","exifImageWidth":4032,"exifImageHeight":3024,"fileSizeInByte":1559892,"orientation":"6","dateTimeOriginal":"2023-05-17T15:26:03.000Z","modifyDate":"2023-05-17T15:26:03.000Z","timeZone":"UTC+1","lensModel":"iPhone 13 Pro back triple camera 1.57mm f/1.8","fNumber":1.8,"focalLength":1.6,"iso":800,"exposureTime":"1/60","latitude":null,"longitude":null,"city":null,"state":null,"country":null,"description":""},"smartInfo":{"tags":null,"objects":["person"]},"livePhotoVideoId":null,"tags":[],"people":[],"checksum":"SBwtl9FL41xzPLS6PrI/XTVfo38="}

jmbenevise commented 1 year ago

Same problem here. I have quite a few pictures with invalid/empty coordinates. Until Version 1.58.0, it was fine, and Map tab was working fine. Having to identify these pictures and correct the EXIF data would be very boring. I would rather downgrade to 1.58.0 until there is a patch.

michelheusschen commented 1 year ago

Oh v1.58.0 was fine? There haven't been any changes since directly related to the map. And what exactly do you mean with invalid/empty, are the latitude and longitude values null or a number that is an invalid coordinate? Do you have the same error in the browser's console?

I'm having a hard time reproducing the issue, even with all the information already given.

jmbenevise commented 1 year ago

EXIF tool is displaying GPS Latitude Ref: Unknown () Browser console is showing null

michelheusschen commented 1 year ago

Are you able to share any asset that causes this problem?

jmbenevise commented 1 year ago

20230204_122735

michelheusschen commented 1 year ago

Thank you, I can see the problem now. I'll start working on a fix.

jmbenevise commented 1 year ago

Sorry, the problem was already there on 1.58.0. I will restore 1.57.1 and check again.

jmbenevise commented 1 year ago

Confirmed, V1.57.1 was fine.