immich-app / immich

High performance self-hosted photo and video management solution.
https://immich.app
GNU Affero General Public License v3.0
53.15k stars 2.81k forks source link

[BUG] Reassigning a face to a new person from a video silently fails #5539

Closed eygraber closed 11 months ago

eygraber commented 12 months ago

The bug

I have a video which has the wrong person tagged as a face. If I try to reassign to a new face, there is no error in the browser console or server logs, but it keeps the person that was tagged before. I can reassign to an existing face.

The OS that Immich Server is running on

Ubuntu 22.04

Version of Immich Server

v1.90.0

Version of Immich Mobile App

v1.90.0

Platform with the issue

Your docker-compose.yml content

version: "3.8"

services:
  immich-server:
    user: 1000:1001
    container_name: immich_server
    image: ghcr.io/immich-app/immich-server:${IMMICH_VERSION:-release}
    command: [ "start.sh", "immich" ]
    volumes:
      - ${UPLOAD_LOCATION}:/usr/src/app/upload
    env_file:
      - .env
    ports:
      - "2283:3001"
    depends_on:
      - redis
      - database
      - typesense
    restart: always

  immich-microservices:
    user: 1000:1001
    container_name: immich_microservices
    image: ghcr.io/immich-app/immich-server:${IMMICH_VERSION:-release}
    # extends:
    #   file: hwaccel.yml
    #   service: hwaccel
    command: [ "start.sh", "microservices" ]
    volumes:
      - /disks/storage/immich/volumes/geocoding:/usr/src/app/.reverse-geocoding-dump
      - ${UPLOAD_LOCATION}:/usr/src/app/upload
    env_file:
      - .env
    depends_on:
      - redis
      - database
      - typesense
    restart: always

  immich-machine-learning:
    user: 1000:1001
    container_name: immich_machine_learning
    image: ghcr.io/immich-app/immich-machine-learning:${IMMICH_VERSION:-release}
    volumes:
      - /disks/storage/immich/volumes/model-cache:/cache
    env_file:
      - .env
    restart: always

  typesense:
    container_name: immich_typesense
    image: typesense/typesense:0.24.1@sha256:9bcff2b829f12074426ca044b56160ca9d777a0c488303469143dd9f8259d4dd
    environment:
      - TYPESENSE_API_KEY=${TYPESENSE_API_KEY}
      - TYPESENSE_DATA_DIR=/data
      # remove this to get debug messages
      - GLOG_minloglevel=1
    volumes:
      - /disks/storage/immich/volumes/tsdata:/data
    restart: always

  redis:
    container_name: immich_redis
    image: redis:6.2-alpine@sha256:70a7a5b641117670beae0d80658430853896b5ef269ccf00d1827427e3263fa3
    restart: always

  database:
    user: 1000:1001
    container_name: immich_postgres
    image: postgres:14-alpine@sha256:28407a9961e76f2d285dc6991e8e48893503cc3836a4755bbc2d40bcc272a441
    env_file:
      - .env
    environment:
      POSTGRES_PASSWORD: ${DB_PASSWORD}
      POSTGRES_USER: ${DB_USERNAME}
      POSTGRES_DB: ${DB_DATABASE_NAME}
    volumes:
      - /disks/storage/immich/volumes/pgdata:/var/lib/postgresql/data
    restart: always

Your .env content

# You can find documentation for all the supported env variables at https://immich.app/docs/install/environment-variables

PUID=1000
GUID=1001

# The location where your uploaded files are stored
UPLOAD_LOCATION=/disks/storage/immich/library

# The Immich version to use. You can pin this to a specific version like "v1.71.0"
IMMICH_VERSION=release

# Connection secrets for postgres and typesense. You should change these to random passwords
TYPESENSE_API_KEY=...
DB_PASSWORD=...

TZ=America/New_York

# The values below this line do not need to be changed
###################################################################################
DB_HOSTNAME=immich_postgres
DB_USERNAME=postgres
DB_DATABASE_NAME=immich

REDIS_HOSTNAME=immich_redis

Reproduction steps

1. Go to video
2. Open the info window
3. Click edit people
4. Tap the remove icon on the incorrect person
5. Click the + in the top right corner
6. Select face closes and nothing changes

Additional information

No response

alextran1502 commented 12 months ago

Can you reproduce this on all videos?

eygraber commented 12 months ago

So far it's been reproduced on all videos that I've tried.

alextran1502 commented 12 months ago

Hmm, very strange, I cannot reproduce it on my instance

alextran1502 commented 12 months ago

Could it be related to issue #5538 on your instance?

alextran1502 commented 12 months ago

would it work if you remove user: 1000:1001 from the services in your docker-compose file?

eygraber commented 12 months ago

I don't know enough to say if it's related to #5538 or not, but I wouldn't think so.

Also not sure about removing user: 1000:1001 because otherwise my filesystem gets screwed up (everything gets written as root, which I don't want). However, everything has been working fine until this update, so I think it makes more sense to be that a bug that was introduced.

alextran1502 commented 12 months ago

I don't know enough to say if it's related to #5538 or not, but I wouldn't think so.

Also not sure about removing user: 1000:1001 because otherwise my filesystem gets screwed up (everything gets written as root, which I don't want). However, everything has been working fine until this update, so I think it makes more sense to be that a bug that was introduced.

That makes sense, let's see if we have similar reporting issues.