search

immich-app / immich

High performance self-hosted photo and video management solution.
https://immich.app
GNU Affero General Public License v3.0
44.52k stars 2.16k forks source link

[BUG] Left/Right swipe through images on Immich mobile app animation is too slow #5895

Open NicholasFlamy opened 8 months ago

NicholasFlamy commented 8 months ago

The bug

The left or right swipe animation is too long and often is a problem when attempting to take other actions in the mobile app. This has been a reported problem to users in the past but they did not understand the cause of their problem. Zoom issue: #2765 Discussion relating to this: #4005

The OS that Immich Server is running on

N/A

Version of Immich Server

N/A

Version of Immich Mobile App

All versions in the past year or more

Platform with the issue

Your docker-compose.yml content

N/A

Your .env content

N/A

Reproduction steps

1. Open the immich app.
2. Tap on an image.
3. Swipe left or right between images.
4. Right after swiping try zooming in, swiping up to open information, or swiping down to return to timeline view.
5. Observe that often your swipes will be treated as left or right swipes if you do not wait long enough after swiping left or right before making another action.

Additional information

Everything was tested on the Immich demo server. The screen recordings of Immich and Google Photos are on my Samsung Galaxy S21 5G running Android 13 OneUI 5.1.

Immich acts completely independent of the animation scale developer options: https://cdn.discordapp.com/attachments/994044917355663450/1182411884255793264/Screen_Recording_20231207_150150.mp4?ex=658dd461&is=657b5f61&hm=b66bac91ffc3d8b8af51d52cb7c02d57d500fe24146745a4bf9a7c9aad22b643&

Right/Left swipe in Google Photos is independent, but up/down is dependent on the developer option: https://cdn.discordapp.com/attachments/994044917355663450/1182412597870461038/Screen_Recording_20231207_150423_Photos.mp4?ex=658dd50b&is=657b600b&hm=14873f4ca6bd152dfc1a628aaf24574c2844d577a72db36a63d1ad0b7f2afbfe&

If I swipe up or down while the swipe left or right animation is playing in Google Photos it counts as a left or right swipe so that is the same as Immich but this animation is much shorter in Google Photos so I was only able to do this by purposefully trying to go too fast: https://cdn.discordapp.com/attachments/994044917355663450/1182418282423275662/Screen_Recording_20231207_152708_Photos.mp4?ex=658dda56&is=657b6556&hm=09ec31da069106a4a43a7c083b56b62566ff11e6e97f3d672ed91e004b6b34d7&

Some more demonstrations: https://photos.app.goo.gl/RonpTwFi8dts2Hky7

The animation speed is slow, and also Immich has a Jelloey effect where you can swipe past the image and it comes back whereas Google Photos (as well as other Gallery apps like Samsung Gallery) smooth this animation and don't let it go past the image: https://cdn.discordapp.com/attachments/994044917355663450/1182431811364716594/Screen_Recording_20231207_162135.mp4?ex=658de6f0&is=657b71f0&hm=8d1b7935ac41aadb32b2ee01127b4b3846285221646b6de0a7342f1db51ae9f1&

The following videos are (as is visible since I videoed the screen) on an iPhone 8+. It is running iOS 16.7.2 and the latest Immich app on the demo server The full video demonstrating the issue occurring on the iOS app identically to on Android: https://photos.app.goo.gl/LYgpue1ocJyBFVsP9

The clip highlighting the slow animation and how the image is almost but not completely lined up in frame: https://cdn.discordapp.com/attachments/994044917355663450/1182437154329215056/20231207_163248_2.mp4?ex=658debea&is=657b76ea&hm=ab4577efd885b1b21e86c9bc91967285025768ff612457429846e2bf8557fed3&

NicholasFlamy commented 8 months ago

One more media item in #2765: https://github.com/immich-app/immich/assets/8555749/94ab43ec-4535-4bd2-9b78-bb5608f0dff2

NicholasFlamy commented 4 months ago

FYI, this is still the case. Just did a check up.

NicholasFlamy commented 4 months ago

2765 is considered fixed, in the video sent by the user it is still possible to simulate what was done but now the animation of swiping between photos is faster so it's better than when I filed this issue.

Still it's not quite there, Google Photos still does it better. It has this sort of a motorized effect. Description of what Google Photos is doing that makes it better:

  1. You swipe slowly to the next image and as soon as you let go it quickly accelerates to a "Minimum Speed Limit" and if you swipe fast it can play the animation faster than this.
  2. When you swipe to the next image, fast or slow, hard or soft, it has a sort of a catch, like an elevator emergency brake that won't let the elevator go past the floor it's going to no matter what. Hard fast swipe in immich will go to the next image and partly show you the next next image before moving back to the image you were swiping to.
  3. The last part of the animation, right before it ends on the image, is much faster in Google Photos, it's like they didn't allow it to exponentially decay or they cut off the decay right when it got close to finished. This cutoff point for immich is so much lower that it spends a lot of the time of the animation between photos right when it is almost to the next photo. The problem with this, is that anytime it is animating the swipe between photos, you CANNOT do any other swipe gesture except swiping between photos, so zooming, opening the info, swiping down and out of the photo view do not work.