immich-app / immich

High performance self-hosted photo and video management solution.
https://immich.app
GNU Affero General Public License v3.0
44.7k stars 2.17k forks source link

Cant persist docker volume for Immich unless this line is being modified #6836

Closed jslearn81 closed 7 months ago

jslearn81 commented 7 months ago

The bug

In https://github.com/immich-app/immich/releases/latest/download/docker-compose.yml

Originally:

This was also noticed in the following reddit post. https://www.reddit.com/r/immich/comments/18h5trn/immich_is_not_moving_files_from_upload_to_library/

The OS that Immich Server is running on

Windows

Version of Immich Server

latest/docker

Version of Immich Mobile App

V1.0.0

Platform with the issue

Your docker-compose.yml content

version: "3.8"

#
# WARNING: Make sure to use the docker-compose.yml of the current release:
#
# https://github.com/immich-app/immich/releases/latest/download/docker-compose.yml
#
# The compose file on main may not be compatible with the latest release.
#
# Nas example: https://www.reddit.com/r/immich/comments/18h5trn/immich_is_not_moving_files_from_upload_to_library/

name: immich
services:
  immich-server:
    container_name: immich_server
    image: ghcr.io/immich-app/immich-server:${IMMICH_VERSION:-release}
    command: [ "start.sh", "immich" ]
    volumes:
      - ${UPLOAD_LOCATION}:/usr/src/app/upload/upload
      - /etc/localtime:/etc/localtime:ro
    env_file:
      - .env
    ports:
      - 2283:3001
    depends_on:
      - redis
      - database
    restart: always

  immich-microservices:
    container_name: immich_microservices
    image: ghcr.io/immich-app/immich-server:${IMMICH_VERSION:-release}
    # extends: # uncomment this section for hardware acceleration - see https://immich.app/docs/features/hardware-transcoding
    #   file: hwaccel.transcoding.yml 
    #   service: cpu # set to one of [nvenc, quicksync, rkmpp, vaapi, vaapi-wsl] for accelerated transcoding
    command: [ "start.sh", "microservices" ]
    volumes:
      - ${UPLOAD_LOCATION}:/usr/src/app/upload/upload
      - /etc/localtime:/etc/localtime:ro
    env_file:
      - .env
    depends_on:
      - redis
      - database
    restart: always

Your .env content

NA

Reproduction steps

NA

Additional information

No response

bo0tzz commented 7 months ago

That change in isolation (without the other mounts that the reddit post lists) is certainly wrong and will result in lost files.