Closed Snowknight26 closed 3 months ago
Thanks for the report and example image. Could you double-check the permissions of that link? I can't access it.
FWIW I locally opened the two example images for this camera from https://raw.pixls.us and the compressed one displays with the weird black border while the lossless one has some vignetting in the corners. The same occurs in immich.
However, there's a new option as of 1.102.0 to use the embedded preview for RAW images and I can confirm it works well for this camera. I recommend enabling this setting and re-running thumbnail generation for images from this camera.
Thanks for the report and example image. Could you double-check the permissions of that link? I can't access it.
Fixed.
However, there's a new option as of 1.102.0 to use the embedded preview for RAW images and I can confirm it works well for this camera.
Sweet, looking forward to it.
v1.102.0 using the new preview option produces even worse results. I mean.. technically the black border is gone, but at what cost? 😛
Left is RAW, right is JPG exported from RAW.
It looks like there's an issue with how the preview image is produced to begin with - it has no metadata and the image looks like this locally as well. There's not much for an image converter to work with there. I checked the other example images and the same is true there as well; they just happened to produce a more normal looking image. The colors on them are still off upon closer inspection.
The issue with the RAW conversion seems to be that there are two different kinds of dimensions listed in the metadata: ImageHeight
and ExifImageHeight
(same for width and size as well). The former is what we use (and what the image processing libraries presumably use), while the latter is what has the correct dimensions for the image. Fixing it in our metadata extraction is easy, but the issue in image processing should be handled upstream. I think this is probably a libvips issue: libraw is only used for decoding the source image, while generating the converted image is handled in libvips.
Edit: It actually does look to be a libraw issue since I can reproduce it with their dcraw_emu
CLI.
I tested with the latest snapshot of libraw and still had this issue. Are you okay with me using this link as an example image for the issue?
Never mind! I was apparently still using the release version. The recent snapshot does actually fix this issue.
Fixed via #10457
The bug
The thumbnail conversion that's done for RAWs made by a Sony ILCE-6700 (Alpha 6700) adds black borders to the image, regardless of thumbnail size.
On top of that, the dimensions reported by immich are also incorrect.
immich:
Lightroom, which matches JPGs made from the RAW:
Digging deeper into it it seems like it could be be because immich is using an older version of libraw that maybe doesn't fully support them.
Example file: https://drive.google.com/file/d/1erUSAJzyDywxfsG_nTXjrMwSc8VItMUQ/view?usp=sharing
The OS that Immich Server is running on
Windows 10 22H2 (19045.4291)
Version of Immich Server
1.101.0
Version of Immich Mobile App
N/A
Platform with the issue
Your docker-compose.yml content
Your .env content
Reproduction steps
Relevant log output
No response
Additional information
No response