refactor(web): search people

immich-app / immich

High performance self-hosted photo and video management solution.

https://immich.app

GNU Affero General Public License v3.0

33.02k stars 1.59k forks source link

refactor(web): search people #9082

Closed martabal closed 2 weeks ago

martabal commented 2 weeks ago

This PR aims to simplify and reduce bugs with search people. Currently there are multiple implementations for the same search, this PR creates a new modal for all person search.

fix #5571

cloudflare-pages[bot] commented 2 weeks ago

Deploying immich with Cloudflare Pages

Latest commit:	`f4ca564`
Status:	✅ Deploy successful!
Preview URL:	https://0b7f0693.immich.pages.dev
Branch Preview URL:	https://fix-refactor-search-people.immich.pages.dev

View logs

martabal commented 2 weeks ago

Yes, the logic is complex, we can probably optimize it but we will probably hit some limits. I prefer to have one complex component rather than writing the same component/handler multiple times.