immich-app / immich

High performance self-hosted photo and video management solution.
https://immich.app
GNU Affero General Public License v3.0
33.04k stars 1.59k forks source link

fix(cli): dry run being inaccurate #9088

Closed mertalev closed 2 weeks ago

mertalev commented 2 weeks ago

Description

The dry run always returns an empty list for the list of new assets, meaning it will always report that it would create 0 new albums. This PR changes this to return a list of dummy assets instead for accurate reporting.

It also adds a bunch of e2e tests for dry runs since we seem to not test this flag at all right now.

Lastly, it makes dry runs incompatible with the --skip-hash flag since duplicates can't be accurately handled in this case.

Fixes #8966

How Has This Been Tested?

Tested that the dry run lines up with the real run with a number of different commands.