The ability to choose the format means that it's no longer enough to overwrite a preview or thumbnail asset: in cases where the old path differs from the new, the old file will be left behind. This PR explicitly checks for this case and deletes the old path.
There is a bit of duplication here since the check is added separately for previews and thumbnails. I did this to make the behavior more transparent: the generateThumbnail helper should only generate an image, not have a side effect of deleting another file.
Fixes #8981
How Has This Been Tested?
Tested by checking that there are only a few untracked assets in the repair page, changing the target thumbnail and preview formats, re-running thumbnail generation and confirming there's no explosion of untracked files after thumbnail generation is complete.
Description
The ability to choose the format means that it's no longer enough to overwrite a preview or thumbnail asset: in cases where the old path differs from the new, the old file will be left behind. This PR explicitly checks for this case and deletes the old path.
There is a bit of duplication here since the check is added separately for previews and thumbnails. I did this to make the behavior more transparent: the
generateThumbnailhelper should only generate an image, not have a side effect of deleting another file.Fixes #8981
How Has This Been Tested?
Tested by checking that there are only a few untracked assets in the repair page, changing the target thumbnail and preview formats, re-running thumbnail generation and confirming there's no explosion of untracked files after thumbnail generation is complete.