search

immich-app / immich

High performance self-hosted photo and video management solution.
https://immich.app
GNU Affero General Public License v3.0
33.03k stars 1.59k forks source link

feat(server, web): album order preference #9135

Open martabal opened 2 weeks ago

martabal commented 2 weeks ago

The goal is to have a new user settings to choose the default album order (the option is saved in db). The options are Backward and Forward.

Screenshots

User settings : Screenshot from 2024-04-28 15-17-37

cloudflare-pages[bot] commented 2 weeks ago

Deploying immich with  Cloudflare Pages  Cloudflare Pages

Latest commit: d5d0258
Status: ✅  Deploy successful!
Preview URL: https://65c47480.immich.pages.dev
Branch Preview URL: https://feat-preference-album-order.immich.pages.dev

View logs

jrasm91 commented 1 week ago

Why don't you convert this to ready for review after you have removed the per album/user sorting setting. I think we can keep the default sort order per person, and default to that setting for any new albums, but we don't need per user sort settings for each album.

danieldietzler commented 1 week ago

Why don't you convert this to ready for review after you have removed the per album/user sorting setting. I think we can keep the default sort order per person, and default to that setting for any new albums, but we don't need per user sort settings for each album.

Martabal reverted that, no? Afaict this PR now only has (1) default setting per user and (2) sorting order per album (not per album per user).

martabal commented 4 days ago

Yep, I think that's how we decided it to be :thinking: