search

immich-app / immich

High performance self-hosted photo and video management solution.
https://immich.app
GNU Affero General Public License v3.0
39.01k stars 1.84k forks source link

Edited photos on iPhone are not synced automatically #9250

Open mplonski opened 2 months ago

mplonski commented 2 months ago

The bug

Whenever you edit a photo on iPhone, immich app should detect it and reupload it automatically. Currently it's not detected and one needs to delete a photo in immich, and reupload it using in-app backup.

The OS that Immich Server is running on

official docker image run within UnRaid

Version of Immich Server

v1.103.1

Version of Immich Mobile App

v1.103.0

Platform with the issue

Your docker-compose.yml content

I don't have one - it's deployed using UnRaid plugin

Your .env content

I don't have one - it's deployed using UnRaid plugin

Reproduction steps

1. take a picture on iPhone
2. upload it to Immich using in-app backup
3. make sure it's uploaded to Immich server
4. edit the photo on iPhone (e.g. crop it)
5. trigger backup in Immich app
6. nothing happens, the photo should be updated

Relevant log output

No response

Additional information

No response

sidamos commented 2 months ago

Same here. And your workaround does not work for me. When I delete the original photo in Immich web, it vanishes also in the iOS app but I cannot trigger manual backup because the button is disabled. The edited photo never appears in the iOS app.

mplonski commented 2 months ago

@sidamos actually, for me the button on the picture view also doesn't do anything, the backup tool in the app does the thing.

alextran1502 commented 2 months ago

When you edit a photo, the Photos app saves a separate XMP file, not a new file; that is why you cannot upload the edited photo

sidamos commented 2 months ago

@sidamos actually, for me the button on the picture view also doesn't do anything, the backup tool in the app does the thing.

Not for me. Once I delete the original in Immich, the edited one never shows up in Immich. My workaround is to duplicate the edited photo in the iOS gallery app.

mplonski commented 2 months ago

@alextran1502 so... is it treated as a separate file when edited? Or backup mechanism in the app doesn't support updating edited files yet? Because at least in my case it uploads the edited version only when I delete the image in the UI, or when the image was never uploaded, it doesn't update it at all when I edit already synced image in the Photos app.

alextran1502 commented 2 months ago

@mplonski

Or backup mechanism in the app doesn't support updating edited files yet

The library we used I believe isn't making this distinction. And we haven't worked on supporting this yet

mplonski commented 1 month ago

@alextran1502 ok, so it looks like it's something between a bug (since the backup function in the app works differently depending on if something was already uploaded) and a feature request (since re-uploading edited pictures is not implemented yet). What's next? I'm not a nodejs engineer, so I won't be able to help here.

snatch84 commented 1 month ago

same problem on android..on the phone I see the edited photo while on the server the original version remains..

justin13888 commented 1 month ago

I lost edited videos from this too before. I think the syncing on the mobile app should just be overhaulled with the caching which is unbelievably slow on mobile. I mentioned that in another discussion: https://github.com/immich-app/immich/discussions/9706

Are any devs looking into this? Otherwise, I may pick it up later when time allows.

Alex9779 commented 3 days ago

This describes one of my major issues pretty much and is a deal breaker for me to use Immich. When I found Immich it still had something like "photo backup" in its description but IMHO it never worked as a real backup solution for photos. After the latest changes (in organization) this part has been removed and now it is "just" a photo management platform. I don't mean this in any negative way. I like the overall concept, open source and everything.

What I expect to be the basic functionalty of every kind of automatic upload functionality is that it either reflects the state I have on my mobile or much better has an original and the edit.

But as this issue describes this is not the case. If you take a photo and upload you have the original on Immich. If you take a photo, edit and upload you have the edit on Immich.

And it is hard to clean this as this issue describes.

The problem with that is that using an automated upload you don't know when this actually runs and you don't know which version of an image is actually uploaded to Immich. Some photos you take and edit right away, some you edit minutes or hours later, some never... That renders the auto upload unusable IMHO and doing everything manually again requires a lot of user interaction. But this is just for experienced users.

I'd love to use it for my whole family, to have an endpoint for all photos take on mobile automatically, but preserving the original photo at least, the latest edit would be a bonus. But in the current state neither is guaranteed. Depending on when the auto upload actually runs, there might be some edit uploaded on Immich and maybe the one where someone accidentially cropped almost the whole picture.

antonyoneill commented 3 days ago

In case you find an alternative solution, I'd be very interested. My issue will be to find a reliable iOS sync to external library I think.

https://github.com/immich-app/immich/discussions/6439#discussioncomment-9912512