immich-app / immich

High performance self-hosted photo and video management solution.
https://immich.app
GNU Affero General Public License v3.0
47.08k stars 2.38k forks source link

CLI tool is not uploading any XMP files #9891

Closed ericswpark closed 3 weeks ago

ericswpark commented 4 months ago

The bug

The CLI tool will not upload any sidecar files. Tested with CLI tool released with v1.105.1

The OS that Immich Server is running on

unRAID

Version of Immich Server

v1.105.1

Version of Immich Mobile App

N/A

Platform with the issue

Your docker-compose.yml content

N/A

Your .env content

N/A

Reproduction steps

1. Upload photos with the CLI tool

The XMP file naming does not seem to matter (i.e. it will not upload `IMG_0001.png.xmp` nor `IMG_0001.xmp`. Capitalization also does not matter (i.e. it will not upload `IMG_0001.XMP`).

Relevant log output

No response

Additional information

No response

mplawner commented 4 months ago

Not sure if this is related, but I noticed that XMP file information is not being read when added to the filesystem either. According to https://immich.app/docs/features/xmp-sidecars/ the XMP data read via CLI or filesystem should take priority over image metadata. As far as I can tell, it's not loaded it all.

ericswpark commented 4 months ago

@mplawner that sounds like it should be filed as a separate issue as it would indicate Immich doesn't support XMP at all despite having it in the docs. I'm curious as to whether it worked previously but was mistakenly broken during feature addition or if it only works when the assets are uploaded via a certain path (maybe the Android app). Because right now uploading via the CLI tool doesn't work, and the iOS app doesn't have support for reading sidecar metadata as the underlying Flutter library can't access it IIRC.

jrasm91 commented 3 weeks ago

This was likely fixed in #9831