imminfo / tcr

[DEPRECATED, see https://immunarch.com/] tcR: an R package for immune receptor repertoire advanced data analysis.
https://immunarch.com/
37 stars 22 forks source link

js.div.seg is not using .quant ! #43

Closed iziziz closed 8 years ago

iziziz commented 8 years ago

I've got pretty same numbers with .quant=NA and .quant='umi.count'

the problem in here:

" js.div.seg function (.data, .genes = HUMAN_TRBV, .frame = c("all", "in", "out"), .quant = c(NA, "read.count", "umi.count", "read.prop", "umi.prop"), .norm.entropy = T, .ambig = F, .verbose = F, .data2 = NULL) ... if (has.class(.genes, "list") && length(.genes) == 2) { freq.alpha <- geneUsage(.data, .genes = .genes, .ambig = .ambig) freq.beta <- geneUsage(.data2, .genes = .genes, .ambig = .ambig) } ... "

ver 2.1.1

IZ

vadimnazarov commented 8 years ago

Done, update is on the develop branch