Additional parameters for function vis.heatmap

imminfo / tcr

[DEPRECATED, see https://immunarch.com/] tcR: an R package for immune receptor repertoire advanced data analysis.

https://immunarch.com/

37 stars 22 forks source link

Additional parameters for function vis.heatmap #59

Closed kvanhoorde closed 8 years ago

kvanhoorde commented 8 years ago

Two additional parameters:

scientific to allow for scientific notation in labeling of heatmap
sizeText to allow to decrease the size of the text in the heatmap

vadimnazarov commented 8 years ago

it doesn't work as expected (returns "scientific" or "value" strings instead of values), however, I fixed this. I will close this pull request, but I will add your changes right now. Thank you!

kvanhoorde commented 8 years ago

I am sorry for the mistake. It had to be "p <- p + geom_text(aes_string(fill = "value", label = label), size = sizeText)" in the code instead of "p <- p + geom_text(aes(fill = value, label = label), size = sizeText)".

kvanhoorde commented 8 years ago

Thanks for your modifications. However it seems to me that in this way the scientific notation is not used since the modification to m is done after supplying m already to ggplot. So I suppose the code that I proposed with the modification as mentioned in my comment before (using "aes_string(fill = "value", label = label)") inside geom_text should fix this issue.