immortius / chunkbychunk

Minecraft mod in which you unlock the world chunk by chunk
Other
17 stars 5 forks source link

Selectable, specific biome spawner #109

Open ChenM0M opened 5 months ago

ChenM0M commented 5 months ago

I hope the mod can incorporate a generator that supports specific mod biomes/structures (Sorry for my poor English, so this content is translated by GPT.)

immortius commented 5 months ago

It is possible to modify the existing themed chunk spawners to set what biomes they incorporate, using the sky dimension data format described here: https://github.com/immortius/chunkbychunk/wiki/Sky-Dimension-Data and a data pack. Is that what you are after?

ChenM0M commented 5 months ago

This is not what I had in mind. What I mean is, could the mod potentially include a generator in future updates that allows for customizing the generation of biomes and structures provided by other mods? For example, a GUI-based generator that allows player to put something(which is configurable), when right-clicked generator, can generate the specified mod structures or biomes.

On a side note, there seems to be an compatibility issue between the mod and alexscaves. When using the locate command to find the corresponding biome location and generating blocks with the generator, the mod content does not appear. In the vanilla version (without the chunkbychunk mod), I tested seed 7845676164001321752, and the spawn point located magnetic_caves, successfully generating the corresponding biome content. However, when the mod is installed and the generator is used, the content of the biome does not appear. If it possible fix this compatibility issue with alexscaves in a future update?

immortius commented 5 months ago

I'll have a look at alexcaves as part of #96 - I was lacking an example before so it is good to have a concrete case to explore.

I'm not currently looking to add major features to Chunk By Chunk. Otherwise, it is not impossible to have a specific biome spawning block and prompting for it via a list. Spawning structures are not something Chunk By Chunk handles at all currently, and I haven't come up with a decent approach to handle them since they're not constrained to a chunk. I'll reopen this as something to think about if I want to add more features in the future though.

ChenM0M commented 5 months ago

Got it.By the way, I'd like to mention that the testing environment for 'alexscaves' is Version 1.20.1, Forge Version 47.2.0, AlexCaves Version 1.0.9, and ChunkByChunk Version 2.1.1. Hope this information is helpful for troubleshooting the issue :)

immortius commented 5 months ago

I'm still investigating this, but I note that Alex's Caves has configuration files for each biome that include specifying which dimension they should be spawned into, which at the very least needs to include chunkbychunk:skychunkgeneration to work with chunk by chunk.

ChenM0M commented 5 months ago

Sorry for my oversight regarding the dimension configuration files you mentioned. This time, I have correctly modified the configuration files for all cave systems. However, I still encountered some issues. Despite using the seed 7845676164001321752, the magnetic_caves biome is now generating, but I noticed some differences compared to the save files without the chunkbychunk mod. For instance, at the coordinates 120, 5, -2102, there should be a properly generated small house within the magnetic_caves biome, and the surrounding cave spaces should be substantial. However, after installing the chunkbychunk mod, large caverns are not being generated, and there are no small houses in that location.

immortius commented 5 months ago

I'm not reproducing the issue.

ChenM0M commented 5 months ago

I use a new modpack which only includes ChunkandChunk and Alex'sCaves,that i find i couldn't reproducing the issue too. Last time i test with another modpack which has other mods,So I think it should be that changes in other modules to world generation result in some variations in the appearance of the generated biomes. It's an oversight on my part.

immortius commented 4 months ago

All good.