search

immunant / c2rust

Migrate C code to Rust
https://c2rust.com/
Other
3.79k stars 219 forks source link

Fix nix build #1047

Closed HKalbasi closed 7 months ago

HKalbasi commented 7 months ago
HKalbasi commented 7 months ago

I think the CI failure is unrelated, but if it is not then please help me to fix it.

thedataking commented 7 months ago

I think the CI failure is unrelated, but if it is not then please help me to fix it.

Yes, one failure is a likely a permissions problem (c2rust-testsuite) which you can ignore. The other was a macOS provisioning problem which is hopefully (🤞) fixed now.

HKalbasi commented 7 months ago

I don't really know much about nix so I can't really review that part of it. I think if this works for you on nix then it's fine, though

I can add nix build to CI to check that it works and prevent regressions in future, if desired.

thedataking commented 7 months ago

I can add nix build to CI to check that it works and prevent regressions in future, if desired.

As Khyber said on another PR, we do not maintain the nix files for Rust but accept patches when something breaks. Kind of you to offer though; thanks!

HKalbasi commented 7 months ago

Anything else to do on this?