immutability-io / vault-ethereum

A plugin that turns Vault into an Ethereum wallet.
243 stars 65 forks source link

ability to sign transactions without sending them - default is to send #24

Closed cypherhat closed 6 years ago

cypherhat commented 6 years ago

Description

A feature was requested that the plugin be able to sign transactions. Since this capability already existed in the context of debit, contract deploy, and erc20 transfer operations, it was thought to extend these features by adding a flag that can inhibit the sending of the transaction. In any case, the signed transaction is returned.

Motivation and Context

Developer ease of use - if a developer only wants to sign transactions, that capability should be allowed.

How Has This Been Tested?

Call the debit, contract deploy, and erc20 transfer operations with send=false and with the default send=true.

Screenshots (if appropriate):

Types of changes

Checklist: