immutability-io / vault-ethereum

A plugin that turns Vault into an Ethereum wallet.
243 stars 65 forks source link

Moved to coinmarketcap API pro/v1 #48

Closed cypherhat closed 5 years ago

cypherhat commented 5 years ago

Description

Moved to using the pro version of the Coinmarketcap API. The configuration variable api_key was previously defined to be the Infura API key. That was actually a documentation/design error - the Infura API key can be simply added to the Infura URL - there was no need for an Infura API key.

Motivation and Context

The Coinmarketcap v1 and v2 APIs are going away. The pro version (v1) is a completely different API. It requires an API Key - but there is a free tier (the hobbyist tier). This tier is rate limited.

How Has This Been Tested?

Tested convert operation with and without api_key being configured.

Screenshots (if appropriate):

Types of changes

Checklist: