immutability-io / vault-ethereum

A plugin that turns Vault into an Ethereum wallet.
243 stars 65 forks source link

go mod dependency mgmt and workound bug fix to broken dependency #55

Closed richard-mauri closed 5 years ago

richard-mauri commented 5 years ago

See my comment in https://github.com/immutability-io/vault-ethereum/issues/51

Description

introduce two go mod init generated files: go.mod and go.sum using latest available dependencies except for github.com/miguelmota/go-coinmarketcap which has a bad commit at this time (so using the . prior commit)

Motivation and Context

When a breaking api change happens to any package in the transitive dependencie then this project would also break. This dependency management helps stabilize the builds but special conscious care must be made to pull in new version dependencies or new packages altogether. Read about go module here: https://github.com/golang/go/wiki/Modules

https://github.com/immutability-io/vault-ethereum/issues/51

How Has This Been Tested?

The build has beeen tested. The runtime needs to be tested still.

go install (after using go mod and go dep to set the base dependency versions

go version go1.11.4 darwin/amd64

Screenshots (if appropriate):

Types of changes

Checklist:

richard-mauri commented 5 years ago

I added commit to this PR to adjust the breaking API change.