immutability-io / vault-ethereum

A plugin that turns Vault into an Ethereum wallet.
243 stars 65 forks source link

WIP: Goreleaser cross compile and resolve #2 #65

Closed zambien closed 5 years ago

zambien commented 5 years ago

This PR aims to solve two issues.

2 which is an issue with running under Alpine

Cross compilation

Description

The Dockerfile is relatively straightforward. It provides the required setup to compile the plugin natively in Alpine and shows how to copy that compiled plugin to another docker container.

The goreleaser implementation shows how to compile and how to release. Updates are in the readme. However there is a problem. We don't get signed releases. So I would recommend that we use goreleaser for the convenience of cross-platform compiles but create releases as we do today.

Would appreciate review/feedback prior to merge.