search

immutability-io / vault-ethereum

A plugin that turns Vault into an Ethereum wallet.
244 stars 66 forks source link

fix: add encoding argument on accounts/:name/sign #75

Closed mortimr closed 4 years ago

mortimr commented 4 years ago

Added an encoding argument on the mount-path/accounts/:name/sign call. This argument was required in order to have a proper keccak256 hash result of an hex encoded payload.

mortimr commented 4 years ago

@cypherhat, Do I have to manually update the doc or is there a documentation generator ? If it's manual, tell me and I'll add the extra info.

cypherhat commented 4 years ago

The doc is not generated. You will need to add the doc to this PR. Thanks so much.

mortimr commented 4 years ago

@cypherhat, can you wait before merging ? I have a final test to do this evening if I get the time. I'll ping you when it seems all fine

cypherhat commented 4 years ago

Absolutely. Ping me - I should be online.

mortimr commented 4 years ago

Hi @cypherhat, all seems fine, merge whenever you want