immutability-io / vault-ethereum

A plugin that turns Vault into an Ethereum wallet.
244 stars 66 forks source link

fix: adding prefix for personal message sign #79

Open MonarthS opened 4 years ago

MonarthS commented 4 years ago

In general, the personal message sign is generated with prefix \x19Ethereum Signed Message:\n. So compared to other, this prefix is required to get same signature as others (for ex: metamask).

cypherhat commented 4 years ago

Can you pull from master (i drastically changed the plugin) and submit this again?

MonarthS commented 4 years ago

Okay, need to check this as I can't see the method pathSign in path_accounts.go.

cypherhat commented 4 years ago

It's called sign-tx now.