immutability-io / vault-ethereum

A plugin that turns Vault into an Ethereum wallet.
244 stars 66 forks source link

FIxes gasLimit parse bug & updates vault and go #89

Closed wistefan closed 2 years ago

wistefan commented 2 years ago

Description

The PR updates the go-lang version and the vault-dependencies. Beside that, a fix for parsing the gas_limit from request is provided. Previous implementation ignored the provided gas_limit and took the default value in all cases. The fix does only take the default, if not gas_limit is provided.

Motivation and Context

  1. Plugin should run with latest vault
  2. I want to use the plugin for signing transactions. This requires proper handling of the gas_limit field.

Types of changes

Checklist:

wistefan commented 2 years ago

@cypherhat is this repo still active? Or is there a new place to apply PRs? Best, Stefan

cypherhat commented 2 years ago

sorry - lot of life things :)

wistefan commented 2 years ago

@cypherhat No problem, thank you for merging. Very nice plugin, btw.