search

immutable-js-oss / immutable-js

Immutable persistent data collections for Javascript which increase efficiency and simplicity.
https://immutable-js-oss.github.io/immutable-js/
MIT License
37 stars 6 forks source link

Benchmark the PRs that have been merged since we forked #210

Closed Methuselah96 closed 3 years ago

Methuselah96 commented 3 years ago

I made https://github.com/immutable-js-oss/immutable-js/issues/208 for introducing automated testing, however that might be too much work to get done for the next release. This issue is to track manually running benchmarks for PRs that have been merged since we forked. We're close to releasing the next RC release, and this is one of the last things to do!

PRs to benchmark:

Going forward, I would like to do the performance testing before a PR is merged, whether that is automatic or we have to do it manually.

Methuselah96 commented 3 years ago

Regression due to https://github.com/immutable-js-oss/immutable-js/issues/210 (see benchmark code in https://github.com/immutable-js-oss/immutable-js/pull/211):

image

Methuselah96 commented 3 years ago

Regression due to https://github.com/immutable-js-oss/immutable-js/pull/206 (see benchmark code in https://github.com/immutable-js-oss/immutable-js/pull/211):

image

Methuselah96 commented 3 years ago

I've made separate issues for each performance regression.