Closed jasonzwli closed 9 months ago
Generated at commit: 9bfb7001f2d454e503688005cf95fd8c372f4b1b
🚨 Report Summary
Severity Level Results Contracts Critical High Medium Low Note Total 2 0 0 8 30 40 Dependencies Critical High Medium Low Note Total 0 0 0 1 54 55
For more details view the full report in OpenZeppelin Code Inspector
Adding OperaterAllowlistUpgradeable. The reasoning for not just overwriting the original OAL code is because the repo is fairly out of date with its packages, i.e overwriting the existing contract requires ethers ^6.6.0, which will break 95% of our hardhat tests. This is time consuming to fix, so I made the decision to write a new contract and test the essential proxy functions in forge. I've also replaced the OAL in the ERC1155 test with the new OALUpgradeable to test its interactions with collections. The regular Allowlist contract will be removed from the repo once we fix the tests that are written in hardhat