[NO-JIRA] Using oz burnable preset

immutable / contracts

Smart contracts for developers in the Immutable ecosystem.

Other

36 stars 34 forks source link

[NO-JIRA] Using oz burnable preset #202

Closed audityourcontracts closed 4 months ago

audityourcontracts commented 5 months ago

Added OZ's ERC20Burnable dependency which gives you burn() and burnFrom() as standard burn functions. This simplifies ImmutableERC20 contract enabling the existing burn() function to be removed.

Added a test testBurnFrom() which ensures you need approval before using burnFrom(). It tests the happy and unhappy paths.

You can run the test with;

forge test --match-test testBurnFrom -vvvvv

drinkcoffee commented 5 months ago

I suggest we close this PR in favour of https://github.com/immutable/contracts/pull/204 Thoughts @audityourcontracts @rytimx @jasonzwli

audityourcontracts commented 5 months ago

Agreed.

drinkcoffee commented 4 months ago

Closing this PR