When integrating the Core SDK with the Wallet SDK, I found that most wallets don’t allow eth_signTransaction to sign raw transactions. This limitation means we cannot implement the signTransaction in the Wallet SDK. The fix is to use eth_sendTransaction in the WalletSDK instead, and therefore the SignersignTransaction method needs to change to sendTransaction.
Things worth calling out
Purposely kept WorkflowsendTransaction to return EthSendTransaction (instead of changing it to a string for transaction hash) as it is clearer to understand.
Examples and README will be updated in another PR when I prepare for the release.
Before merging
[x] For Immutable developers: Do the changes in this PR require documentation updates? Please refer to this SDK documentation guide and list links to documentation update PRs (they don't have to be merged) below (or write N/A):
Summary
Change
SignersignTransactiontosendTransaction.Why the changes
When integrating the Core SDK with the Wallet SDK, I found that most wallets don’t allow
eth_signTransactionto sign raw transactions. This limitation means we cannot implement thesignTransactionin the Wallet SDK. The fix is to useeth_sendTransactionin the WalletSDK instead, and therefore theSignersignTransactionmethod needs to change tosendTransaction.Things worth calling out
WorkflowsendTransactionto returnEthSendTransaction(instead of changing it to a string for transaction hash) as it is clearer to understand.Before merging
N/A):N/A