immux / immux1

https://immux.com
0 stars 0 forks source link

Realistic benchmark improvements #148

Closed blaesus closed 5 years ago

blaesus commented 5 years ago

1. Separate realistic benchmarks

berka99 and census90 are put into separate directories with independent entry in Cargo.toml. That means they can be run independently:

cargo bench --bench berka99
cargo bench --bench census90

2. Flexible parameters

Realistic benchmarks can now tweak its row_limit and report_period with command-line arguments:

// row_limit is 1000, report_period is 100
cargo bench --bench berka99 -- 1000 100

3. Correctness check

Realistic benchmarks can now check correctness of the benchmark operations. It is turned on by the third argument:

cargo bench --bench berka99 -- 1000 100 1

4. HTTP download for realistic data

The CSV files were controlled in a git submodule, which relies on LFS. It has increased complexity and the hit the quota system of GitHub. Now we just download them via HTTP.

blaesus commented 5 years ago

@poppindouble Please let the author merge the PR next time, thanks.