search

imneme / pcg-cpp

PCG — C++ Implementation
Apache License 2.0
735 stars 98 forks source link

Makefile: Fix install target. #48

Closed gerasiov closed 5 years ago

gerasiov commented 5 years ago

Signed-off-by: Alexander GQ Gerasiov gq@cs.msu.su

NAThompson commented 5 years ago

I've hit this bug as well. Looks like your fix is good to me, although I would add that you can take all of the dependencies for install.

imneme commented 5 years ago

I've merged a similar change that doesn't use =?. I don't think that's necessary. Feel free to complain if you're sure I'm mistaken.

NAThompson commented 5 years ago

Just tested your fix and it works.

BTW since all that the install target does is copy header files into some syspath, there's no need to have it depend on the all target, esp. if the system doesn't have gcc.

Just my two bits!

imneme commented 5 years ago

Interesting point about the dependency on all.

But it does serve as a sanity check. If those things don't compile, it's questionable whether it's a good idea to install the headers. And, if the system doesn't have a compiler, installing a header-only library doesn't seem like it makes a lot of sense.

NAThompson commented 5 years ago

@imneme : I was mainly thinking about when Microsoft comes out with its command line terminal this summer only msvc will be expected to be available on Windows. (Of course, they could override the compiler on the command line.) More of a nitpick I admit.