search

imodeljs / create-react-app

Set up a modern web app by running one command.
https://create-react-app.dev
MIT License
2 stars 7 forks source link

react-scripts: fix leftover issue from #106; bump @babel/core to fix visitor issue #108

Closed ben-polinsky closed 11 months ago

ben-polinsky commented 11 months ago

react-scripts:

Fix #106 left a case where copyPluginPatterns was an empty array, which is an invalid value for the CopyPlugin's patterns option in webpack configuration.

Fix an issue where babel would report You gave us a visitor for the node type ClassAccessorProperty but it's not a valid type when encountering a class accessor (contained in @itwin/browser-authentication in this case). See: https://github.com/babel/babel/issues/15765 for similar reports.

ben-polinsky commented 11 months ago

Could you bump the patch version manually?

Yes, forgot when I learned I needed to fork.

ben-polinsky commented 11 months ago

@aruniverse that's done. I assume the builds are a bit flaky? I see past PRs merged with a few failing checks.